Discussion:
[jira] [Created] (THRIFT-3219) Provide a C++ tutorial on server-side IP logging and per-connection state
(too old to reply)
Ben Craig (JIRA)
2015-07-02 19:13:04 UTC
Permalink
Ben Craig created THRIFT-3219:
---------------------------------

Summary: Provide a C++ tutorial on server-side IP logging and per-connection state
Key: THRIFT-3219
URL: https://issues.apache.org/jira/browse/THRIFT-3219
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.9.3
Reporter: Ben Craig






--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2015-07-03 01:59:04 UTC
Permalink
[ https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14612753#comment-14612753 ]

ASF GitHub Bot commented on THRIFT-3219:
----------------------------------------

GitHub user ben-craig opened a pull request:

https://github.com/apache/thrift/pull/538

THRIFT-3219: Provide a C++ tutorial on server-side IP logging and per-connection state

This also adds the C++ tutorial builds to the cmake build by default.

The tutorial demonstrates per-connection state as a side effect.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/ben-craig/thrift THRIFT-3219

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/thrift/pull/538.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #538

----
commit fe8bba275a84ea059ce36344dd160121d2518e5c
Author: Ben Craig <***@apache.org>
Date: 2015-07-03T01:29:52Z

Adding C++ tutorials to default CMake build

commit b20fe4b5fdac66ce9b980d0cfc34951dcbadc6a0
Author: Ben Craig <***@apache.org>
Date: 2015-07-03T01:55:45Z

Adding C++ IP Logging server tutorial

----
Post by Ben Craig (JIRA)
Provide a C++ tutorial on server-side IP logging and per-connection state
-------------------------------------------------------------------------
Key: THRIFT-3219
URL: https://issues.apache.org/jira/browse/THRIFT-3219
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.9.3
Reporter: Ben Craig
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2015-07-04 08:19:05 UTC
Permalink
[ https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613604#comment-14613604 ]

ASF GitHub Bot commented on THRIFT-3219:
----------------------------------------

Github user bufferoverflow commented on a diff in the pull request:

https://github.com/apache/thrift/pull/538#discussion_r33885841

--- Diff: CMakeLists.txt ---
@@ -73,6 +73,7 @@ endif()

if(BUILD_CPP)
add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/lib/cpp)
+ add_subdirectory(${CMAKE_CURRENT_SOURCE_DIR}/tutorial/cpp)
if(BUILD_TESTING)
--- End diff --

we probably need to add a BUILD_TUTORIALS option in the future
Post by Ben Craig (JIRA)
Provide a C++ tutorial on server-side IP logging and per-connection state
-------------------------------------------------------------------------
Key: THRIFT-3219
URL: https://issues.apache.org/jira/browse/THRIFT-3219
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.9.3
Reporter: Ben Craig
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2015-07-04 08:20:04 UTC
Permalink
[ https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613605#comment-14613605 ]

ASF GitHub Bot commented on THRIFT-3219:
----------------------------------------

Github user bufferoverflow commented on a diff in the pull request:

https://github.com/apache/thrift/pull/538#discussion_r33885850

--- Diff: tutorial/cpp/CppLogIPServer.cpp ---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <thrift/concurrency/ThreadManager.h>
+#include <thrift/concurrency/PosixThreadFactory.h>
+#include <thrift/protocol/TBinaryProtocol.h>
+#include <thrift/server/TThreadedServer.h>
+#include <thrift/transport/TServerSocket.h>
+#include <thrift/transport/TSocket.h>
+#include <thrift/transport/TTransportUtils.h>
+#include <thrift/TToString.h>
+
+#include <boost/make_shared.hpp>
+
+#include <iostream>
+#include <stdexcept>
+#include <sstream>
+
+#include "../gen-cpp/Calculator.h"
+
+using namespace std;
+using namespace apache::thrift;
+using namespace apache::thrift::concurrency;
+using namespace apache::thrift::protocol;
+using namespace apache::thrift::transport;
+using namespace apache::thrift::server;
+
+using namespace tutorial;
+using namespace shared;
+
+class CalculatorHandler : public CalculatorIf {
+public:
+ CalculatorHandler() {}
+
+ void ping() { cout << "ping()" << endl; }
+
+ int32_t add(const int32_t n1, const int32_t n2) {
+ cout << "add(" << n1 << ", " << n2 << ")" << endl;
+ return n1 + n2;
+ }
+
+ int32_t calculate(const int32_t logid, const Work& work) {
+ cout << "calculate(" << logid << ", " << work << ")" << endl;
+ int32_t val;
+
+ switch (work.op) {
+ case Operation::ADD:
+ val = work.num1 + work.num2;
+ break;
+ case Operation::SUBTRACT:
+ val = work.num1 - work.num2;
+ break;
+ case Operation::MULTIPLY:
+ val = work.num1 * work.num2;
+ break;
+ case Operation::DIVIDE:
+ if (work.num2 == 0) {
+ InvalidOperation io;
+ io.whatOp = work.op;
+ io.why = "Cannot divide by 0";
+ throw io;
+ }
+ val = work.num1 / work.num2;
+ break;
+ default:
+ InvalidOperation io;
+ io.whatOp = work.op;
+ io.why = "Invalid Operation";
+ throw io;
+ }
+
+ SharedStruct ss;
+ ss.key = logid;
+ ss.value = to_string(val);
+
+ log[logid] = ss;
+
+ return val;
+ }
+
+ void getStruct(SharedStruct& ret, const int32_t logid) {
+ cout << "getStruct(" << logid << ")" << endl;
+ ret = log[logid];
+ }
+
+ void zip() { cout << "zip()" << endl; }
+
+protected:
+ map<int32_t, SharedStruct> log;
+};
+
+class CalculatorCloneFactory : virtual public CalculatorIfFactory {
+ public:
+ virtual ~CalculatorCloneFactory() {}
+ virtual CalculatorIf* getHandler(const ::apache::thrift::TConnectionInfo& connInfo)
+ {
+ boost::shared_ptr<TSocket> sock = boost::dynamic_pointer_cast<TSocket>(connInfo.transport);
+ cout << "Incoming connection\n";
+ cout << "\tSocketInfo: " << sock->getSocketInfo() << "\n";
+ cout << "\tPeerHost: " << sock->getPeerHost() << "\n";
+ cout << "\tPeerAddress: " << sock->getPeerAddress() << "\n";
+ cout << "\tPeerPort: " << sock->getPeerPort() << "\n";
+ return new CalculatorHandler;
+ }
+ virtual void releaseHandler( ::shared::SharedServiceIf* handler) {
+ delete handler;
+ }
+};
+
+int main() {
+ TThreadedServer server(
+ boost::make_shared<CalculatorProcessorFactory>(boost::make_shared<CalculatorCloneFactory>()),
--- End diff --

I would say we can add this to the regular Tutorial server and add some
Post by Ben Craig (JIRA)
Provide a C++ tutorial on server-side IP logging and per-connection state
-------------------------------------------------------------------------
Key: THRIFT-3219
URL: https://issues.apache.org/jira/browse/THRIFT-3219
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.9.3
Reporter: Ben Craig
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2015-07-04 15:20:04 UTC
Permalink
[ https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14613893#comment-14613893 ]

ASF GitHub Bot commented on THRIFT-3219:
----------------------------------------

Github user ben-craig commented on a diff in the pull request:

https://github.com/apache/thrift/pull/538#discussion_r33888179

--- Diff: tutorial/cpp/CppLogIPServer.cpp ---
@@ -0,0 +1,138 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+#include <thrift/concurrency/ThreadManager.h>
+#include <thrift/concurrency/PosixThreadFactory.h>
+#include <thrift/protocol/TBinaryProtocol.h>
+#include <thrift/server/TThreadedServer.h>
+#include <thrift/transport/TServerSocket.h>
+#include <thrift/transport/TSocket.h>
+#include <thrift/transport/TTransportUtils.h>
+#include <thrift/TToString.h>
+
+#include <boost/make_shared.hpp>
+
+#include <iostream>
+#include <stdexcept>
+#include <sstream>
+
+#include "../gen-cpp/Calculator.h"
+
+using namespace std;
+using namespace apache::thrift;
+using namespace apache::thrift::concurrency;
+using namespace apache::thrift::protocol;
+using namespace apache::thrift::transport;
+using namespace apache::thrift::server;
+
+using namespace tutorial;
+using namespace shared;
+
+class CalculatorHandler : public CalculatorIf {
+public:
+ CalculatorHandler() {}
+
+ void ping() { cout << "ping()" << endl; }
+
+ int32_t add(const int32_t n1, const int32_t n2) {
+ cout << "add(" << n1 << ", " << n2 << ")" << endl;
+ return n1 + n2;
+ }
+
+ int32_t calculate(const int32_t logid, const Work& work) {
+ cout << "calculate(" << logid << ", " << work << ")" << endl;
+ int32_t val;
+
+ switch (work.op) {
+ case Operation::ADD:
+ val = work.num1 + work.num2;
+ break;
+ case Operation::SUBTRACT:
+ val = work.num1 - work.num2;
+ break;
+ case Operation::MULTIPLY:
+ val = work.num1 * work.num2;
+ break;
+ case Operation::DIVIDE:
+ if (work.num2 == 0) {
+ InvalidOperation io;
+ io.whatOp = work.op;
+ io.why = "Cannot divide by 0";
+ throw io;
+ }
+ val = work.num1 / work.num2;
+ break;
+ default:
+ InvalidOperation io;
+ io.whatOp = work.op;
+ io.why = "Invalid Operation";
+ throw io;
+ }
+
+ SharedStruct ss;
+ ss.key = logid;
+ ss.value = to_string(val);
+
+ log[logid] = ss;
+
+ return val;
+ }
+
+ void getStruct(SharedStruct& ret, const int32_t logid) {
+ cout << "getStruct(" << logid << ")" << endl;
+ ret = log[logid];
+ }
+
+ void zip() { cout << "zip()" << endl; }
+
+protected:
+ map<int32_t, SharedStruct> log;
+};
+
+class CalculatorCloneFactory : virtual public CalculatorIfFactory {
+ public:
+ virtual ~CalculatorCloneFactory() {}
+ virtual CalculatorIf* getHandler(const ::apache::thrift::TConnectionInfo& connInfo)
+ {
+ boost::shared_ptr<TSocket> sock = boost::dynamic_pointer_cast<TSocket>(connInfo.transport);
+ cout << "Incoming connection\n";
+ cout << "\tSocketInfo: " << sock->getSocketInfo() << "\n";
+ cout << "\tPeerHost: " << sock->getPeerHost() << "\n";
+ cout << "\tPeerAddress: " << sock->getPeerAddress() << "\n";
+ cout << "\tPeerPort: " << sock->getPeerPort() << "\n";
+ return new CalculatorHandler;
+ }
+ virtual void releaseHandler( ::shared::SharedServiceIf* handler) {
+ delete handler;
+ }
+};
+
+int main() {
+ TThreadedServer server(
+ boost::make_shared<CalculatorProcessorFactory>(boost::make_shared<CalculatorCloneFactory>()),
--- End diff --

Ok, combined the old and the new tutorials in the latest commit.
Post by Ben Craig (JIRA)
Provide a C++ tutorial on server-side IP logging and per-connection state
-------------------------------------------------------------------------
Key: THRIFT-3219
URL: https://issues.apache.org/jira/browse/THRIFT-3219
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.9.3
Reporter: Ben Craig
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2015-07-04 20:11:04 UTC
Permalink
[ https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614038#comment-14614038 ]

ASF GitHub Bot commented on THRIFT-3219:
----------------------------------------

Github user bufferoverflow commented on the pull request:

https://github.com/apache/thrift/pull/538#issuecomment-118548352

Thanks Ben!
Could you commit this?
Post by Ben Craig (JIRA)
Provide a C++ tutorial on server-side IP logging and per-connection state
-------------------------------------------------------------------------
Key: THRIFT-3219
URL: https://issues.apache.org/jira/browse/THRIFT-3219
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.9.3
Reporter: Ben Craig
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Ben Craig (JIRA)
2015-07-04 22:22:04 UTC
Permalink
[ https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ben Craig resolved THRIFT-3219.
-------------------------------
Resolution: Fixed
Assignee: Ben Craig
Post by Ben Craig (JIRA)
Provide a C++ tutorial on server-side IP logging and per-connection state
-------------------------------------------------------------------------
Key: THRIFT-3219
URL: https://issues.apache.org/jira/browse/THRIFT-3219
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.9.3
Reporter: Ben Craig
Assignee: Ben Craig
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
ASF GitHub Bot (JIRA)
2015-07-04 22:22:04 UTC
Permalink
[ https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614076#comment-14614076 ]

ASF GitHub Bot commented on THRIFT-3219:
----------------------------------------

Github user asfgit closed the pull request at:

https://github.com/apache/thrift/pull/538
Post by Ben Craig (JIRA)
Provide a C++ tutorial on server-side IP logging and per-connection state
-------------------------------------------------------------------------
Key: THRIFT-3219
URL: https://issues.apache.org/jira/browse/THRIFT-3219
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.9.3
Reporter: Ben Craig
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Ben Craig (JIRA)
2015-07-04 22:23:04 UTC
Permalink
[ https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ben Craig closed THRIFT-3219.
-----------------------------
Post by Ben Craig (JIRA)
Provide a C++ tutorial on server-side IP logging and per-connection state
-------------------------------------------------------------------------
Key: THRIFT-3219
URL: https://issues.apache.org/jira/browse/THRIFT-3219
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.9.3
Reporter: Ben Craig
Assignee: Ben Craig
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
Hudson (JIRA)
2015-07-04 22:47:04 UTC
Permalink
[ https://issues.apache.org/jira/browse/THRIFT-3219?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14614082#comment-14614082 ]

Hudson commented on THRIFT-3219:
--------------------------------

SUCCESS: Integrated in Thrift #1591 (See [https://builds.apache.org/job/Thrift/1591/])
THRIFT-3219 Provide a C++ tutorial on server-side IP logging and (bencraig: rev 74086f18afa336000c3cf210939b1a1b843faaa5)
* tutorial/cpp/CppServer.cpp
* CMakeLists.txt
* tutorial/cpp/CMakeLists.txt
Post by Ben Craig (JIRA)
Provide a C++ tutorial on server-side IP logging and per-connection state
-------------------------------------------------------------------------
Key: THRIFT-3219
URL: https://issues.apache.org/jira/browse/THRIFT-3219
Project: Thrift
Issue Type: Improvement
Components: C++ - Library
Affects Versions: 0.9.3
Reporter: Ben Craig
Assignee: Ben Craig
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Loading...